This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[Minor] Fix typing extension import for tests #4190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm getting a bunch of test errors and it's annoying. Based off of https://github.com/huggingface/huggingface_hub/pull/453/files (which is the solution to huggingface/huggingface_hub#452 ) it seems like changing this version should be what we need...
moyapchen
changed the title
moyapchen
requested review from
klshuster,
stephenroller and
EricMichaelSmith
stephenroller
approved these changes
Nov 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm getting a bunch of test errors and it's annoying. Based off of
https://github.com/huggingface/huggingface_hub/pull/453/files
(which is the solution to huggingface/huggingface_hub#452 )
it seems like changing this version should be what we need...
Testing steps
Creating this PR, seeing if it yells at me in the CircleCi bit.